Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Add option for configuring true depth threshold directly #339

Closed
wants to merge 457 commits into from
Closed

Add option for configuring true depth threshold directly #339

wants to merge 457 commits into from

Conversation

alvinsunyixiao
Copy link
Contributor

@alvinsunyixiao alvinsunyixiao commented Jun 3, 2020 •
edited
Loading

For RGBD sensors using technologies other than stereo vision (e.g. coded light, laser, etc.), it does not make sense to have a focal_x_baseline. Could we add configuration options to directly specify true depth threshold for RGBD sensors?

shinsumicco and others added 30 commits June 18, 2019 02:25
@shinsumicco
Merge pull request xdspacelab#62 from shinsumicco/refactor/angle-checker
1e7e211 
Refactor matchers by implementing an angle checker class
@shinsumicco
Modify the cmake error message
b4e1739
@saweer
Refactor the utils for EuRoC dataset
d5669a4
@saweer
Refactor the utils for KITTI dataset
8d1117e
@saweer
Refactor the utils for image sequence
87cc613
@saweer
Add exception handling
3d73d99
@saweer
Implement examples for TUM-RGBD dataset
1658f94
@saweer
Add config files for TUM-RGBD dataset
50663f3
@saweer
Insert comments to rgbd_tracking() accrording to the ones in mono_tra…
90566b1 
…cking()
@saweer
Load timestamps and filepaths from rgb.txt and depth.txt
76744bf
@shinsumicco
Merge pull request xdspacelab#61 from saweer/feat/tum-rgbd-example
d067b27 
Implementation of examples for TUM-RGBD dataset
@shinsumicco
Merge pull request xdspacelab#60 from saweer/refactor/example-utils
2d0b2c0 
Refactoring of the utilities for the examples
@shinsumicco
Use unique-pointer for the modules in the global optimizer
928df61
@shinsumicco
Use unique-pointer for the modules in the mapper
52ef4e7
@shinsumicco
Merge pull request xdspacelab#65 from shinsumicco/fix/module-as-smart…
4a07666 
…-ptr

Use std::unique_ptr for the modules contained as class members
@shinsumicco
Remove the const qualifier
164e337
@shinsumicco
Include <cmath>
aafd862
@shinsumicco
Use SSE instruction for rotations of point pairs
bc7e04b
@shinsumicco
Add a cmake option for SSE-based floating-point operation (-mfpmath=sse)
82e5de2
@shinsumicco
Compatible with macOS
7e00e30
@shinsumicco
Add SSE configuration to the CI setting
3b6c525
@shinsumicco
Merge pull request xdspacelab#59 from shinsumicco/refactor/orb-extractor
380876a 
Use SSE instructions for point rotation in ORB extraction
@saweer
Enable ccache to accelerate a build
2c1cb6e
@shinsumicco
Merge pull request xdspacelab#68 from saweer/feat/use-ccache
ac05383 
Use ccache to accelerate a build
@shinsumicco
Add a config file for Travis CI
3263d14
@shinsumicco
Add a badge to README.md
151d567
@shinsumicco
Use ccache
244f8b2
@shinsumicco
Merge pull request xdspacelab#69 from xdspacelab/feat/ci-on-macos
c507bf8 
Setup CI on macOS
@shinsumicco
Change the dataset
25ffbf1
@shinsumicco
Merge pull request xdspacelab#70 from xdspacelab/fix/change-ci-dataset
796332f 
Change the dataset for CI
dkarlo2 and others added 22 commits January 15, 2020 15:34
@dkarlo2 @shinsumicco
fix frame statistics replace (xdspacelab#214)
4a3cde9
@keredson @shinsumicco
added dep for eigen (xdspacelab#223)
1c684fb
@shinsumicco
Disable the build support for libopenexr in TravisCI configuration (x…
7f1b2ba 
…dspacelab#226)
@LynnChan706
fix keyframe src_frm_id load error from json with wrong keywords n_ke…
a4c8b41 
…ypts (xdspacelab#251)
@shinsumicco
Merge pull request xdspacelab#254 from shinsumicco/fix/gtest-version
51806a3 
Fix the version of google-test
@shinsumicco
Use flooring instead of rounding when computing a grid index
57ed306
@shinsumicco
Add a test code for data::get_cell_indices(...)
53a6968
@shinsumicco
Disable clang-format for comments in the test code
ef8f22c
@shinsumicco
Renormalize a normal vector when computing it using some observation …
4d9cb5d 
…vectors (xdspacelab#255)
@shinsumicco
Merge pull request xdspacelab#256 from shinsumicco/fix/coords-roundin…
bab1008 
…g-for-grid

Use flooring instead of rounding when computing a grid index
@reunanen
Update end iterator in case keyframe is added
064ee23 
(cherry picked from commit c04bfa0)
@reunanen
Simplify the fix as per review feedback
06b4b16
@yukatayu
fixed undefined behavior
5f2ede8
@shinsumicco
Merge pull request xdspacelab#258 from reunanen/fix-221
4b18d9a 
Use correct end iterator in case keyframe is added
@shinsumicco
Merge pull request xdspacelab#260 from yukatayu/master
9674a32 
Fixed undefined behavior
@yukatayu
fix: boundary check
890315e
@shinsumicco
Merge pull request xdspacelab#284 from yukatayu/master
5a0b1a5 
Fixed boundary check
@alvinsunyixiao
fix socket publisher install directory
80fb897
@shinsumicco
Merge pull request xdspacelab#336 from alvinsunyixiao/socket_publisher
dd8af1c 
fix socket publisher install directory
@alvinsunyixiao
add option for configuring true depth threshold directly
1e109d2
@alvinsunyixiao
change to override
6ed7e30
@alvinsunyixiao
format code
ccf007f
@shinsumicco shinsumicco self-requested a review June 4, 2020 05:12
@shinsumicco shinsumicco self-assigned this Jun 4, 2020
@shinsumicco shinsumicco added bug Something isn't working enhancement New feature or request labels Jun 4, 2020
@ymd-stella ymd-stella mentioned this pull request Jan 30, 2021
Closed
8 tasks
@ymd-stella ymd-stella mentioned this pull request May 7, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shinsumicco shinsumicco Awaiting requested review from shinsumicco

Assignees

@shinsumicco shinsumicco

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet