WIP: feat: add active effects to items

[jonepatr]

NOT READY FOR MERGE as it depends on the migration PR.

• Please check if the PR fulfills these requirements

• We use semantic versioning (https://github.com/semantic-release/semantic-release to be specific), so follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines
• Docs have been added / updated (for bug fixes / features)

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  feature

• What is the current behavior? (You can also link to an open issue here)
  Previsouly adding a trait did not affect the actor.

• What is the new behavior (if this is a feature change)?
  This change makes
  it so that a trait is an active effect and can change the
  actor.

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  It comes with a migration to ensure backward compability.

• Other information:
  Fix 272

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[marvin9257]

Oddly, I'm getting this error when the system initializes. Not certain why. Let me check in the base system.

Just checked with version 1.3.6 - no error

[marvin9257]

What is this supposed to look like? I'm not certain what the header ("starting with "Attribute Key") does.

At least, there is a localization missing.

[marvin9257]

When I edit a new effect - I get this warning.

I think it has to do with the color not having an initial value. Is there a way to initialize as black or white when called?

[jonepatr]

Oddly, I'm getting this error when the system initializes. Not certain why. Let me check in the base system.

Just checked with version 1.3.6 - no error

This has to do with the new dynamic import stuff I'm pretty sure. From the looks of it, I think you have a .DS_Store file in the hooks folder. The dynamic import takes all files in the hooks/template/migrations folder and adds them to the system. For now, try removing the .DS_Store. The proper sollution is to filter out those files in the rollup.config.js script

[jonepatr]

What is this supposed to look like? I'm not certain what the header ("starting with "Attribute Key") does.

At least, there is a localization missing.

So the three headers there were supposed to be the same as if you go into the active effect and add effects.

[jonepatr]

When I edit a new effect - I get this warning.

I think it has to do with the color not having an initial value. Is there a way to initialize as black or white when called?

Hm, what is it that should have a color? the item or the active effect? or something else?

[marvin9257]

Yes, it is when I put the edit effect button.
When the window opens the tint color is blank. If it is set to something the warning message doesn't appear.

[marvin9257]

.DS_Store

Hmm...I can't find this file in the folder - or anywhere when I search - except for another program

[marvin9257]

I went through the Active effects PR and it looks great. I pushed a commit with some suggested styling tweaks. I also fixed a missing label for the effect on create. One thing I noticed it that if the item is dropped into a ship's locker, the active effect can't be edited. Is that the desired function? (duplicate message from discord)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[marvin9257]

Replaced by #1197