-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Redo of active effects #1197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previsouly adding a trait did not affect the actor. This change makes it so that a trait is an active effect and can change the actor. Fix xdy#272
If char changes in pop-up, recal encumbered modifier if needed
Closed
Closed
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
# [2.15.0](v2.14.7...v2.15.0) (2023-01-27) ### Features * Add active effects to Twodsix Actors ([#1197](#1197)) ([a24c076](a24c076))
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
No active effects for items or actors
What is the new behavior (if this is a feature change)?
Add active effects for items
Add active effects tab on actor sheet and add ability to create/edit/delete
Include roll and damage modifiers for consumables (only magazines can have damage modifiers)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
also completes Investigate what supporting Active Effects could bring to Twodsix #273