Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP download loses a few bytes #661

Closed
jmaassen opened this issue Sep 9, 2019 · 2 comments
Closed

FTP download loses a few bytes #661

jmaassen opened this issue Sep 9, 2019 · 2 comments
Assignees
@jmaassen
Labels
Bug

Comments

@jmaassen
Copy link
Member

jmaassen commented Sep 9, 2019

When downloading a larger file with FTP (about 10MB), the resulting file was missing the last few hundred bytes.

It seems to depend on the file how much is lost. Two different sized files gave different results, but copying the same file multiple times leads to the same amount of missing bytes for each file.
@jmaassen jmaassen added the Bug label Sep 9, 2019
@jmaassen jmaassen self-assigned this Sep 9, 2019
@jmaassen
Copy link
Member Author

jmaassen commented Sep 9, 2019

It turned out that the FTP client was still in ASCI mode which means the bytes are actually interpreted in some way when being transferred. After switching to BINARY mode everything works as expected.

Note that we do not catch this in our intergration tests because we only transfer text files there.

@jmaassen
Copy link
Member Author

Fixed in release 3.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmaassen jmaassen

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmaassen