Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with plugins using spigot's library loader #240

Closed
4 tasks done
sarhatabaot opened this issue Apr 12, 2023 · 3 comments
Closed
4 tasks done

Conflict with plugins using spigot's library loader #240

sarhatabaot opened this issue Apr 12, 2023 · 3 comments
Labels
resolution: fixed The bug has been fixed type: bug Something isn't working

Comments

@sarhatabaot
Copy link

Agreements

  • I am running the latest version of Nova.
  • I am running the latest version of my server software.
  • I have checked for similar issues.
  • I am using an official build of Nova.

Before creating a bug report, please validate that the issue you're encountering is not caused by another plugin (Remove all other plugins from the server). If it is, please name the plugin that causes the issue.

This issue is about a specific plugin incompatibility.

Plugin Version, Server Software, Server Version

Nova v0.13-alpha.1, git-Purpur-1957 (MC: 1.19.4)*

Nova Addons and Versions

jetpacks v0.1.8-RC, simple_upgrades v1.0-RC, logistics v0.2.4-RC, machines v0.4-RC

Expected behavior

  1. Plugin "ConfigurableMenus" should load.

Observed/Actual behavior

The plugin "ConfigurableMenus" cannot load class net.kyori.adventure.platform.bukkit.BukkitAudiencesImpl although it uses spigot's library loading feature.
See error & log linked below.

If I remove Nova it loads properly.

Steps to reproduce

  1. Install ConfigurableMenus.
  2. Run the server.

Full server log

https://pastebin.com/3QJEZPA4

Errors

https://pastebin.com/sDnkqTvq

Additional context

No response

@sarhatabaot sarhatabaot added the type: bug Something isn't working label Apr 12, 2023
@NichtStudioCode
Copy link
Member

NichtStudioCode commented Apr 12, 2023

Is it intentional that ConfigurableMenus is also a fat jar that includes kyori-adventure's classes?
image

Anyway, this still shouldn't happen, I'll look into it

@sarhatabaot
Copy link
Author

sarhatabaot commented Apr 12, 2023

Is it intentional that ConfigurableMenus is also a fat jar that includes kyori-adventure's classes? image

Anyway, this still shouldn't happend, I'll look into it

Not intentional. I have fixed it, but the issue is still there.

Anyways, thanks for the help!

@NichtStudioCode NichtStudioCode added the resolution: fixed The bug has been fixed label Apr 12, 2023
@sarhatabaot
Copy link
Author

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: fixed The bug has been fixed type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants