Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend BCFViewPointsPlugin to save & load object colors & opacities #328

Closed
Amoki opened this issue Jun 5, 2020 · 4 comments
Closed

Extend BCFViewPointsPlugin to save & load object colors & opacities #328

Amoki opened this issue Jun 5, 2020 · 4 comments

Comments

@Amoki
Copy link
Contributor

Amoki commented Jun 5, 2020

Currently, the BCF plugin doesn't handle the "color" part.
I'll submit a PR the handle them in setViewpoint but I have some trouble implementing getViewpoint.

We should define "colors" only for objects that have seen their color changed in the current scene. Is there a way to get all the objects with a changed color?

@Amoki Amoki changed the title [BCF] Handle colors [BCF] Handle coloring Jun 8, 2020
Amoki added a commit to Amoki/xeokit-sdk that referenced this issue Jun 8, 2020
Amoki added a commit to Amoki/xeokit-sdk that referenced this issue Jun 8, 2020
@xeolabs
Copy link
Member

xeolabs commented Jun 8, 2020

@Amoki it should be possible to get the IDs of Entity instances that have had their colorize properties modified like this this:

const colorizedObjectIds = myViewer.scene.colorizedObjectIds;

@Amoki
Copy link
Contributor Author

Amoki commented Jun 10, 2020

Thanks, I could develop the coloring part.
I can't find an equivalent for opacity. I tried to loop on objects and check their opacity but I get all windows and transparent doors. Is there a way to retrieve objects that had an opacity change?

@xeolabs
Copy link
Member

xeolabs commented Jun 10, 2020

Yes looks like I need to add something for opacity - I'll take care of this today or tomorrow: #343

@xeolabs
Copy link
Member

xeolabs commented Jun 10, 2020

@Amoki I just added support that this issue needs for opacity: 37dc831

@xeolabs xeolabs changed the title [BCF] Handle coloring Extend BCFViewPointsPlugin to save & load object colors Jun 15, 2020
@xeolabs xeolabs changed the title Extend BCFViewPointsPlugin to save & load object colors Extend BCFViewPointsPlugin to save & load object colors & opacities Jun 15, 2020
@xeolabs xeolabs closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants