Use VAO to save on vertex specifying commands when drawing #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new behavior becomes active if WebGL on the client system supports OES_vertex_array_object. The VAO reference is stored on the geometry chunk. If the interleaved buffer is dirtied and the VAO references it, it is reconstructed based on the regular buffers. The VAO is also reset if the chunk is rebuilt. VAOs are not used if morph geometry is present. OES_vertex_array_object is a widely supported WebGL extension, around 75% of clients have it according to webglstats. In large scenes on CPU-constrained systems that support the extension this patch can increase FPS as much as 15%.
|
This ended up quite complex and is not a very good fit with the current way scene.js handles geometry. I imagine it would be much, much nicer if morphGeometry and geometry nodes were merged into one "VAO/VBO" chunk type when chunks are built and draw calls were in their own chunks. It does have a very nice impact on CPU usage, but I'd at least test this carefully with complex content before merging. |
xeolabs
added a commit
that referenced
this pull request
Jun 25, 2014
Use VAO to save on vertex specifying commands when drawing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new behavior becomes active if WebGL on the client system supports
OES_vertex_array_object. The VAO reference is stored on the geometry
chunk. If the interleaved buffer is dirtied and the VAO references it, it
is reconstructed based on the regular buffers. The VAO is also reset if
the chunk is rebuilt. VAOs are not used if morph geometry is present.
OES_vertex_array_object is a widely supported WebGL extension, around
75% of clients have it according to webglstats. In large scenes on
CPU-constrained systems that support the extension this patch can
increase FPS as much as 15%.