Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove npm package during Demeteorizer.prototype.findDependencies #15

Closed
BretFisher opened this issue Jul 19, 2013 · 1 comment
Closed

remove npm package during Demeteorizer.prototype.findDependencies #15

BretFisher opened this issue Jul 19, 2013 · 1 comment

Comments

@BretFisher
Copy link
Contributor

npm is not needed as a dependency since it's included with node... and now it's hanging up npm install after a demeteorizer because current is 1.3.2 (for 10.x branch) and the package.json is asking for 1.2.2 which causes a failure on npm install.

The fix would be to watch incoming dependencies during folder search and if it was npm, to drop it.

There may be a cleaner way, but I'm working on a fix now.
@InconceivableDuck InconceivableDuck mentioned this issue Jul 19, 2013
Closed
@BretFisher
Copy link
Contributor Author

fixed by commit 4c399d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BretFisher