Deprecates JedisPool returnResource and returnBrokenResource #912
Conversation
| * {@link #persist(byte[]) PERSIST} command. | ||
| * <p> | ||
| * Time complexity: O(1) | ||
| * @deprecated use BinaryJedis.pexpire(byte[], long) or Jedis.pexpire(String,long) Set a timeout |
There was a problem hiding this comment.
Maybe it's unintentional. Could you revert it?
|
Some trivial whitespace issues but LGTM overall. |
|
@HeartSaVioR the format changes are not unintentional i've run |
|
@marcosnils Oh, OK. Look great! |
|
@HeartSaVioR of course!. I totally forgot about those two Pools. I'll update shortly |
|
@HeartSaVioR changes have been made. Can you please review? Thx!. |
| @@ -38,6 +38,10 @@ public ShardedJedis getResource() { | |||
| return jedis; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated starting from Jedis 3.0 this method won't exist. Resouce cleanup should be done | |||
| * using @see {@link redis.clients.jedis.Jedis#close()} | |||
There was a problem hiding this comment.
It should be ShardedJedis#close().
|
@marcosnils Added some note, without these looks great to me! |
|
@HeartSaVioR done!. |
|
Looks good to me. But Travis is failing again :( |
|
I've re-run the tests again. |
|
👍 Let's merge it |
Deprecates JedisPool returnResource and returnBrokenResource
|
Merged into master, 2.6, 2.7 branch respectively. |
|
👍 |
Per #909 as we're planning not to support these methods in the future to avoid confusions.