Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 compatibility #194

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Python 3.8 compatibility #194

merged 3 commits into from
Mar 6, 2020

Conversation

roxyboy
Copy link
Contributor

@roxyboy roxyboy commented Mar 4, 2020

Updated some functions that had deprecation warnings.

@roxyboy
Copy link
Contributor Author

roxyboy commented Mar 4, 2020

The tests all pass in Python 3.6-3.8 but fails in Python 2.7 due to the function dask.drop_vars() not being supported. How do you think about dropping support for Python 2.7 @rabernat ?? Otherwise, I can revert back to using dask.drop() but this will be deprecated in future Python 3 releases.

@rabernat
Copy link
Member

rabernat commented Mar 6, 2020

I think we can drop python 2 in future releases. Thanks for this!

@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #194 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   87.99%   88.07%   +0.08%     
==========================================
  Files          12       12              
  Lines        1633     1644      +11     
  Branches      335      337       +2     
==========================================
+ Hits         1437     1448      +11     
  Misses        158      158              
  Partials       38       38
Impacted Files Coverage Δ
xmitgcm/mds_store.py 92.72% <100%> (+0.06%) ⬆️
xmitgcm/file_utils.py 100% <0%> (ø) ⬆️
xmitgcm/llcreader/known_models.py 78.37% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f505f7...8cc2e92. Read the comment docs.

@roxyboy
Copy link
Contributor Author

roxyboy commented Mar 6, 2020

Ok, all tests in py27 and py3 pass now :)

@rabernat
Copy link
Member

rabernat commented Mar 6, 2020

I guess this will also fix the annoying deprecations warnings from xarray.auto_combine. Great work Takaya!

@rabernat rabernat merged commit 1fb9cc2 into MITgcm:master Mar 6, 2020
fraserwg pushed a commit to fraserwg/xmitgcm that referenced this pull request Nov 23, 2021
* Python 3.8 compatibility

* files for Travis CI

* Added py27 compatibility

Co-authored-by: Uchida Takaya <takachanbo@meom-dyn109.obs.ujf-grenoble.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants