Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subhypergraph leaves unwanted isolated nodes #235

Closed
leotrs opened this issue Dec 2, 2022 · 2 comments · Fixed by #308
Closed

subhypergraph leaves unwanted isolated nodes #235

leotrs opened this issue Dec 2, 2022 · 2 comments · Fixed by #308

Comments

@leotrs
Copy link
Collaborator

leotrs commented Dec 2, 2022

The workaround can be seen here, which is less than ideal IMO.
@leotrs leotrs mentioned this issue Dec 2, 2022
Merged
@maximelucas
Copy link
Collaborator

Would you want subhypergraph(edges) to always get rid of isolated nodes?
Or to have a boolean argument isolated_nodes to have both options?

@leotrs
Copy link
Collaborator Author

leotrs commented Mar 27, 2023

Ya, I think keep_isolates would be nice to have.

@maximelucas maximelucas mentioned this issue Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keep_isolates argument in subhypergraph xgi-org/xgi
2 participants
@leotrs @maximelucas