Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode metadata seems truncated at 35 lines #42

Closed
rnkn opened this issue Jun 11, 2019 · 2 comments
Closed

Episode metadata seems truncated at 35 lines #42

rnkn opened this issue Jun 11, 2019 · 2 comments

Comments

@rnkn
Copy link

rnkn commented Jun 11, 2019

I'm so happy to find castero. Thank you for making it. It's really cool how you appear to have taken inspiration from ncmpcpp and newsbeuter and combined them into an awesome podcast program.

One small thing I've noticed is that the episode metadata pane appears to truncate its content at 35 lines.

Can you reproduce?


~ % sw_vers
ProductName:    Mac OS X
ProductVersion: 10.14.5
BuildVersion:   18F132
~ % pip show castero
Name: castero
Version: 0.5.5
Summary: A TUI podcast client for the terminal
Home-page: https://github.com/xgi/castero
Author: Jake Robertson
Author-email: jake@faltro.com
License: MIT License
Location: /usr/local/lib/python3.7/site-packages
Requires: python-vlc, python-mpv, beautifulsoup4, cjkwrap, requests
Required-by:

(I'm running 0.5.5 as 0.6.0 doesn't seem to have propagated to pypi yet.)

@xgi
Copy link
Owner

xgi commented Jun 11, 2019

Previously I had some code which truncated the description text to a portion of the screen size, and at some point that apparently started truncating the entire metadata display. This caused the description to abruptly cut off as you saw. That has been fixed with dbccf31, so the metadata panel will completely fill up if necessary.

This does not address the fact that we still have text being cut off when it fills the panel. In the future I would like to have controls to scroll through the metadata text (and for the help screen as well). That will be a pretty big change, so I can't commit to a timeline for it.

I'll leave this issue open to address the secondary concern. Thanks!

@rnkn
Copy link
Author

rnkn commented Jun 12, 2019 via email

@xgi xgi closed this as completed in 0937e1a Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants