Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review / improve support for dot-delimited field paths in Store + data package #2886

Open
febbraiod opened this issue Feb 7, 2022 · 2 comments
Assignees
Labels

Comments

@febbraiod
Copy link
Member

When using a dot separated field path to specify a field on a column, it must be specified using the string form of the field:

field: 'levelOne.nestedField'

Using a a config for a typed store field as a dot-separated path causes the value in the column to be null:

field: {name: 'levelOne.nestedField', type: FieldType.NUMBER}

@TomTirapani
Copy link
Member

TomTirapani commented Feb 10, 2022

I took a look at this, and opened a PR to resolve here:

#2890

The above PR allows the store to created the field the same as if it was defined using the string form. However, it should be noted that neither will create a typed store field. Dot-delimited fields are always handled in the store as untyped root fields (i.e. in the above example, what you actually end up with on the store is a levelOne field of type AUTO). This means that there's currently no way to provide a type to nestedField. I think addressing that is beyond the scope of this ticket, just something to be aware of as it may lead to unexpected behaviour throughout the app.

@amcclain amcclain added this to the v47 milestone Mar 3, 2022
@lbwexler lbwexler closed this as completed Mar 4, 2022
@lbwexler
Copy link
Member

lbwexler commented Mar 4, 2022

RE-opening this and reverting the merge after discussion with Tom. We did not want to merge this as we think it really is not helpful to just ignore the user specified type quietly. Reopening ticket for a more expansive discussion

@lbwexler lbwexler reopened this Mar 4, 2022
@lbwexler lbwexler modified the milestones: v47, v48 Mar 4, 2022
@lbwexler lbwexler modified the milestones: v48, Medium Term Apr 14, 2022
@amcclain amcclain added the data label Apr 14, 2022
@amcclain amcclain changed the title Allow defining a typed store field as a dot-separated path Review / improve support for dot-delimited field paths in Store + data package Jun 13, 2024
@amcclain amcclain removed this from the Medium Term milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants