Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor jsp tag handlers to remove duplicated functionality #35

Closed
GoogleCodeExporter opened this issue May 20, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Refactor JSP tag handlers to have duplicated functionality in a common base
class.

What version of the product are you using? On what operating system?

Patch is vs. trunk revision 688

Please provide any additional information below.

        * Refactor common encode tag code to BaseEncodeTag
        * change tags to extend BaseEncodeTag
        * replace tag's implementation of doAfterBody with implementation
                of BaseCodeTag's abstract encode method.
        * bump tag's serialVersionUIDs again as the superclass has changed.
        * add javadoc comments

Original issue reported on code.google.com by schal...@darkmist.net on 15 Oct 2009 at 6:16

Attachments:

@GoogleCodeExporter
Copy link
Author

Blasted... I just realized that I messed up a bit. The new EncodeForHTMLTag is
calling encodeForHTMLAttribute....

Here's the fixed patch...

Original comment by schal...@darkmist.net on 15 Oct 2009 at 7:09

Attachments:

@GoogleCodeExporter
Copy link
Author

Patch applied

Original comment by chrisisbeef on 15 Oct 2009 at 8:51

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant