Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use -ldflags to pass through version and compiler infomation during compile time #9

Closed
sevennt opened this issue May 27, 2019 · 1 comment
Closed

use -ldflags to pass through version and compiler infomation during compile time #9

sevennt opened this issue May 27, 2019 · 1 comment
Labels
discussion This issue needs further discussion

Comments

@sevennt
Copy link
Contributor

sevennt commented May 27, 2019

in core/version.go, you guys defined version and compiler info with hard code.

maybe we can use -ldflags to pass this information during compile time?
@teckick teckick added the discussion This issue needs further discussion label May 27, 2019
@sevennt sevennt mentioned this issue May 30, 2019
Merged
@sevennt
Copy link
Contributor Author

sevennt commented May 31, 2019

#23

@sevennt sevennt closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion This issue needs further discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teckick @sevennt