Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode for Windows? #188

Closed
loyukfai opened this issue Nov 2, 2022 · 12 comments
Closed

Dark Mode for Windows? #188

loyukfai opened this issue Nov 2, 2022 · 12 comments

Comments

@loyukfai
Copy link

loyukfai commented Nov 2, 2022

Is it possible to implement a dark mode for Windows? (and possibly other OS too)

Something just follow the system setting would be nice.

Thanks in advance.

@xiaoyifang
Copy link
Owner

xiaoyifang commented Nov 3, 2022

can be achieved with custom style sheets
https://github.com/goldendict/goldendict/wiki/GoldenDict-Dark-Theme

@loyukfai
Copy link
Author

loyukfai commented Nov 5, 2022

Thanks! But can I make it automatically follow the system-wide theme change which happens on sunrise and sundown?

Cheers.

@leanhdung1994
Copy link

There is a great dark theme here https://github.com/Giai-Ngo/Goldendict-theme/tree/main/Dark%20theme.

@xiaoyifang
Copy link
Owner

license is Attribution-NonCommercial 2.0 Generic (CC BY-NC 2.0)
does it compatible with gpl3?

@leanhdung1994
Copy link

license is Attribution-NonCommercial 2.0 Generic (CC BY-NC 2.0) does it compatible with gpl3?

Honestly, I don't know...

@BEST8OY
Copy link

BEST8OY commented Nov 10, 2022

@xiaoyifang
Why it doesn't get fully dark ?(arch linux)
Screenshot from 2022-11-10 04-01-18

@xiaoyifang
Copy link
Owner

How do you customize the stylesheet?
I guess there are some styles has not been applied.

@BEST8OY
Copy link

BEST8OY commented Nov 10, 2022

How do you customize the stylesheet? I guess there are some styles has not been applied.

I applied them as guided in these two theme
https://github.com/Giai-Ngo/Goldendict-theme/tree/main/Dark%20theme
https://github.com/goldendict/goldendict/wiki/GoldenDict-Dark-Theme
Maybe these themes are old?

@xiaoyifang
Copy link
Owner

xiaoyifang commented Nov 10, 2022

seems like that the style has lack the dark style for toolbar /menu

@xiaoyifang
Copy link
Owner

image

xiaoyifang added a commit that referenced this issue Dec 11, 2022
xiaoyifang added a commit that referenced this issue Dec 11, 2022
@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Dec 22, 2022

On macOS, there is already a native dark mode (with glitches that should be fixed).

On Linux, modifying the default style is a norm. The proper way to have a dark theme on linux should be

  • using a Qt-based DE like lxqt or KDE
  • use Qt theme changer like qt5ct
  • use a DE/disto that has better Qt support like Xfce or Fedora.

Doing dark theming on our side should be limited to Windows only.

Screenshot 2022-12-22 at 12 43 21 AM

@xiaoyifang
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants