Misc issues 4.0.6 #2263
Merged
Misc issues 4.0.6 #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dasgarner
commented
Dec 8, 2023
dasgarner
commented
- Hide canvas region from the thumbnail unless it is the only region. Ensure the thumbnail is generated on publish.
- Format menu board price with 2 decimals on the data entry and widget
- Fix an error on the user grid when a user has a null homepage
- XMDS report fault should protect against super long reasons
- Fix Ad Campaigns add/edit so that impression type can be used
|
TEST: all END |
|
Test Suite: failed ❌ |
|
Test Suite: failed ❌ |
|
TEST: /Layout/Editor/layout_editor_dataset.cy.js END |
|
Test Suite: succeeded ✅ |
ifarzana
previously approved these changes
Dec 8, 2023
ifarzana
approved these changes
Dec 8, 2023
|
TEST: /Layout/Editor/layout_editor_dataset.cy.js END |
|
Test Suite: succeeded ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.