Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge credential files #6

Open
YuKitAs opened this issue Jun 23, 2020 · 2 comments
Open

Merge credential files #6

YuKitAs opened this issue Jun 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@YuKitAs
Copy link
Contributor

YuKitAs commented Jun 23, 2020

Different credential files should be able to be merged.

  • Add new items
  • If name and username are both equal, update password and description with the latest updated timestamp
@xiGUAwanOU
Copy link
Owner

Hey YuKitAs,

thanks for the issue. This feature is actually already implemented if you import another credential file. The imported credential file will be merged with the current one. But the merge implementation is based on an internal UUID instead of name and username. I personally think that comparing with name and username is not quite reliable. What do you think here?

Best regards,
Watermelon

@xiGUAwanOU xiGUAwanOU added the enhancement New feature or request label Jun 23, 2020
@xiGUAwanOU xiGUAwanOU changed the title [Feature request] Merge credential files Merge credential files Jun 23, 2020
@YuKitAs
Copy link
Contributor Author

YuKitAs commented Jun 23, 2020

Relying on unique id sounds better. But sometimes I could create two different entries manually so they will have different IDs. If there is no unique constraint on the name, it just requires some manually cleanup and it would also be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants