Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ncurses dependency from libxrtcore.so #55

Closed
stsoe opened this issue Jul 9, 2018 · 1 comment · Fixed by #58
Closed

Remove ncurses dependency from libxrtcore.so #55

stsoe opened this issue Jul 9, 2018 · 1 comment · Fixed by #58
Assignees
@maxzhen

Comments

@stsoe
Copy link
Collaborator

stsoe commented Jul 9, 2018 •
edited
Loading

Per IM thread, we should probably make sure xbsak.cpp is compiled and linked with only the tools that need it (xbsak and xbflash?). The file should not be included in libxrtcore.so as it adds an otherwise unnecessary dependency on ncurses.

Remove NCURSES_LIBRARIES frm driver/xclng/xrt/CMakeLists.txt
@maxzhen
Copy link
Collaborator

maxzhen commented Jul 9, 2018

I'm going to move it to under tools/xbsak_gem. If anyone knows why we have xbsak.cpp under user_gem today, please let me know.

@maxzhen maxzhen mentioned this issue Jul 10, 2018
Merged
@stsoe stsoe closed this as completed in #58 Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxzhen maxzhen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove dependency of libncurses.so from libxrtcore.so maxzhen/XRT
2 participants
@stsoe @maxzhen