Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad HTTP/1.1 support #8

Closed
jukkagrao opened this issue Jan 18, 2017 · 2 comments
Closed

Bad HTTP/1.1 support #8

jukkagrao opened this issue Jan 18, 2017 · 2 comments

Comments

@jukkagrao
Copy link

jukkagrao commented Jan 18, 2017

Actually there are some points about HTTP/1.1 support (method SOURCE):

  1. When Expect: 100-Continue provided Response code should be
    HTTP/1.1 100 Continue or one of error responses.

Currently:

HTTP/1.1 100 Continue

HTTP/1.0 200 OK

Then it accepts stream.

Status 200 OK (2xx) must be sent only when stream ends, stream should be sent after 100 Continue directly.

  1. When Content-Length is not provided Transfer-Encoding should be chunked
    Transfer-Encoding: chunked
    Currently: Icecast server accepts content without right headers and not chunked stream.
@jukkagrao
Copy link
Author

jukkagrao commented Jan 18, 2017

According this issue there is the same problem in libshout.

And I guess there are similar problems with HTTP/1.0 aka ICE/1.0

@ePirat
Copy link
Contributor

ePirat commented Feb 1, 2017

Thanks for reporting this!
Regarding the first issue, current master only sends HTTP/1.0 200 OK on the end of the stream, not right after the 100 Continue anymore.

Regarding the second, in master we have support for chunked transfer encoding and the source client can use that for PUT with Icecast 2.5. We will not enforce this though, for compatibility reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants