-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix All Compile Warnings. #21
Comments
Every version of every compiler warns about different things, so we can't "fix all compile warnings". We can fix particular warnings, but that requires information about the exact warning, where it's reported, and (often) why it's reported (what the compiler "thinks" is wrong). |
GCC build in Travis has only two warnings: https://travis-ci.org/xiph/opus/jobs/176869299#L675-L677 |
Are there still warnings that need fixing or should we close this? |
Ok, time to build to see if the compile warnigns are all resolved. |
I noticed that when building the 64 bit versions that casts from
int32
to 64 bit generates a warning.Same is true for 32 bit builds saying
cast from int64 to int
warning. Might need to review the code or suppress the warnings (they can be annoying.)The text was updated successfully, but these errors were encountered: