Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix All Compile Warnings. #21

Closed
AraHaan opened this issue Sep 8, 2016 · 4 comments
Closed

Fix All Compile Warnings. #21

AraHaan opened this issue Sep 8, 2016 · 4 comments

Comments

@AraHaan
Copy link

AraHaan commented Sep 8, 2016

I noticed that when building the 64 bit versions that casts from int32 to 64 bit generates a warning.

Same is true for 32 bit builds saying cast from int64 to int warning. Might need to review the code or suppress the warnings (they can be annoying.)

@AraHaan AraHaan changed the title Fix All Ciompile Warnings. Fix All Compile Warnings. Sep 8, 2016
@jmvalin
Copy link
Member

jmvalin commented Nov 11, 2016

Every version of every compiler warns about different things, so we can't "fix all compile warnings". We can fix particular warnings, but that requires information about the exact warning, where it's reported, and (often) why it's reported (what the compiler "thinks" is wrong).

@wiiaboo
Copy link
Contributor

wiiaboo commented Nov 20, 2016

GCC build in Travis has only two warnings: https://travis-ci.org/xiph/opus/jobs/176869299#L675-L677
32-bit VS2015 Release has 26 warnings and 64-bit VS2015 Release has 31. A few of these are in silk fixed files which aren't even used if FIXED_POINT isn't defined.
32-bit and 64-bit VS2015 ReleaseDLL builds don't have as much warnings because they don't compile these FIXED_POINT files.

@jmvalin
Copy link
Member

jmvalin commented Mar 1, 2017

Are there still warnings that need fixing or should we close this?

@ghost ghost closed this as completed in 4d88328 Mar 3, 2017
@AraHaan
Copy link
Author

AraHaan commented Mar 3, 2017

Ok, time to build to see if the compile warnigns are all resolved.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants