Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reduced_still_picture_header when still_picture flag is set #1000

Closed
tdaede opened this issue Feb 14, 2019 · 9 comments · Fixed by #2134
Closed

Use reduced_still_picture_header when still_picture flag is set #1000

tdaede opened this issue Feb 14, 2019 · 9 comments · Fixed by #2134
Labels
AVIF Image Format specific issues enhancement new to rust Good for someone that has little Rust experience.
Projects
Release 0.3

Comments

@tdaede
Copy link
Collaborator

tdaede commented Feb 14, 2019

No description provided.

@shssoichiro shssoichiro added new to rust Good for someone that has little Rust experience. enhancement labels Feb 28, 2019
@rzumer rzumer mentioned this issue Jul 25, 2019
Merged
@rzumer
Copy link
Collaborator

rzumer commented Jul 26, 2019 •
edited

#1498 implements necessary header changes, but we need to implement disable_frame_end_update_cdf before we can enable the reduced header in the Sequence constructor.

@barrbrain barrbrain added this to To do in Release 0.2 via automation Nov 26, 2019
@cryptomilk
Copy link

cryptomilk commented Nov 26, 2019 •
edited

I've just enabled still_picture in libavif and the encoded picture then can't be decoded by dav1d.

cryptomilk added a commit to cryptomilk/libavif that referenced this issue Nov 26, 2019
@cryptomilk
WIP rav1e: Set still picture mode
00e61aa 
This is not fully supported in rav1e yet:
xiph/rav1e#1000
@barrbrain
Copy link
Collaborator

barrbrain commented Nov 26, 2019 •
edited

From AV1 Image File Format (AVIF), 2.1 AV1 Image Item:

  • The AV1 Image Item Data should have its still_picture flag set to 1.
  • The AV1 Image Item Data should have its reduced_still_picture_header flag set to 1.

This issue impacts producing typical sequences for libavif. Emphasis added above.

@lu-zero lu-zero added the AVIF Image Format specific issues label Nov 26, 2019
@cryptomilk cryptomilk mentioned this issue Nov 27, 2019
Closed
@lu-zero lu-zero removed this from To do in Release 0.2 Dec 18, 2019
@lu-zero lu-zero added this to To Do in Release 0.3 Dec 18, 2019
@cryptomilk
Copy link

We have added support for importing and exporting AVIF files in darktable which will be released with version 3.0.1. It would be great to have this fixed in rav1e soon.

@rzumer rzumer mentioned this issue Jan 21, 2020
Merged
@rzumer
Copy link
Collaborator

rzumer commented Jan 22, 2020

@cryptomilk Sorry for the delay in addressing this, I implemented still picture mode a few months back and it seems like other changes in the encoder broke it since then. I will add some tests to avoid future regressions and try to solve the issues found (#2112 and #2113) in a timely manner. In the meantime, #2108 should solve errors when encoding a single image frame, which I think should cover your use case.

@cryptomilk
Copy link

Awesome thanks. I'm travelling this week and will test it next week once i'm back.

@rzumer
Copy link
Collaborator

rzumer commented Jan 24, 2020

Upon further testing there's some extra work to do before the reduced still picture header is supported, hopefully soon. #2108 fixes the still picture mode for any number of frames, without the reduced still picture header (which should be legal AVIF, but not recommended).

@rzumer rzumer mentioned this issue Jan 27, 2020
Merged
Release 0.3 automation moved this from To Do to Done Jan 28, 2020
@cryptomilk
Copy link

@rzumer Thank you very much for fixing this! Now there is one bug/feature left for AVIF and that's lossless support.

@rzumer
Copy link
Collaborator

rzumer commented Jan 28, 2020

@cryptomilk I can't promise that support will be added soon, but I have tagged the corresponding issue (#151) for tracking.

cryptomilk added a commit to cryptomilk/libavif that referenced this issue Jan 28, 2020
@cryptomilk
rav1e: Set still picture mode
8c8580a 
This will be fixed with rav1e 0.3.0, see
xiph/rav1e#1000
cryptomilk added a commit to cryptomilk/libavif that referenced this issue Jan 28, 2020
@cryptomilk
rav1e: Set still picture mode
ff9899e 
This will be fixed with rav1e 0.3.0, see
xiph/rav1e#1000

Fixes AOMediaCodec#33
joedrago pushed a commit to AOMediaCodec/libavif that referenced this issue Jan 28, 2020
@cryptomilk @joedrago
rav1e: Set still picture mode
8b74869 
This will be fixed with rav1e 0.3.0, see
xiph/rav1e#1000

Fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AVIF Image Format specific issues enhancement new to rust Good for someone that has little Rust experience.
Projects
No open projects
Release 0.3
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and enable the reduced still picture header rzumer/rav1e
6 participants
@barrbrain @lu-zero @cryptomilk @tdaede @shssoichiro @rzumer