-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the low_latency option to a flag #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change
Does it now reject --low_latency true/false? If so I'll need to adjust the AWCY arguments to match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
This is a breaking change from the user point of view, maybe we should increase rav1e version to 0.2.0?
We don't have a versioning policy yet, so I just made one: #1231 |
@tdaede, yes, using any value with a flag leads to an error, because flags don't expect values.
I guess the version should change for a specific release, not because of every PR with a breaking change. In other words, it should be okay to have breaking changes in the master (development) branch, but the version number should be increased before making a release. |
Yes, absolutely. |
I guess we could put a label so when we cut releases we won't forget. |
This PR fixes the issue #1224. It changes the low_latency option that takes a boolean value to a flag, which can be used without arguments. If the flag is present, the low latency mode is enabled; otherwise, it's disabled.