Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set_limit from the public API #1239

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Remove set_limit from the public API #1239

merged 1 commit into from
Apr 23, 2019

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Apr 23, 2019

It is not really needed and if we want to continue encoding after a flush we should use a different mean.

@coveralls
Copy link
Collaborator

coveralls commented Apr 23, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 82.584% when pulling 6312a38 on rust-av:drop-set-limit into 122cc8d on xiph:master.

barrbrain
barrbrain reviewed Apr 23, 2019
View reviewed changes
src/bin/rav1e.rs Outdated Show resolved Hide resolved
barrbrain
barrbrain approved these changes Apr 23, 2019
View reviewed changes
Copy link
Collaborator

@barrbrain barrbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revised approach is clearly correct. 👍

@lu-zero lu-zero merged commit 25ab2b2 into xiph:master Apr 23, 2019
@lu-zero lu-zero deleted the drop-set-limit branch April 23, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrbrain barrbrain barrbrain approved these changes

@tdaede tdaede Awaiting requested review from tdaede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lu-zero @coveralls @barrbrain