Strip the local symbols from the nasm objects

[lu-zero]

They tend to confuse the debugger and are overall unnecessary.

[coveralls]

Coverage remained the same at 83.521% when pulling 314f184 on rust-av:strip-nasm into 7970d35 on xiph:master.

[KyleSiefring]

Thanks for doing this.

Unfortunately, it doesn't work on my computer in its current state. It seems to be using the wrong file.
Printing out the path:

panic!("{:?}", Path::new(&out_dir).join("rav1easm.a"));`

thread 'main' panicked at '"/home/kyle/Programming/VideoEncode/rav1e/rav1e/target/release/build/rav1e-388a8ed5e3fac2cf/out/rav1easm.a"', build.rs:153:5

Finding the file:

find . -regextype sed -regex ".*rav1easm.*"

...
./target/debug/build/rav1e-0d4b49c9f2795e3c/out/librav1easm.a
./target/debug/build/rav1e-fddf7b5d00394bfb/out/librav1easm.a
./target/debug/build/rav1e-a356b122f2ada701/out/librav1easm.a
./target/release/build/rav1e-388a8ed5e3fac2cf/out/librav1easm.a

[lu-zero]

right!

…

On Thu, Jul 22, 2021, 02:53 Kyle Siefring ***@***.***> wrote: Doesn't work on my computer. It seems to be using the wrong file. Printing out the path: panic!("{:?}", Path::new(&out_dir).join("rav1easm.a"));` thread 'main' panicked at '"/home/kyle/Programming/VideoEncode/rav1e/rav1e/target/release/build/rav1e-388a8ed5e3fac2cf/out/rav1easm.a"', build.rs:153:5 Finding the file: find . -regextype sed -regex ".*rav1easm.*" ... ./target/debug/build/rav1e-0d4b49c9f2795e3c/out/librav1easm.a ./target/debug/build/rav1e-fddf7b5d00394bfb/out/librav1easm.a ./target/debug/build/rav1e-a356b122f2ada701/out/librav1easm.a ./target/release/build/rav1e-388a8ed5e3fac2cf/out/librav1easm.a — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2762 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB2LJBJLTSA72WAFC7JVQLTY5TYVANCNFSM5AYYSBEQ> .

[KyleSiefring]

I noticed that you switched to -X. This doesn't seem to work, see below.

perf when searching for functions w/ sad

   1.11%  rav1e  rav1e  [.] rav1e_sad16x16_sse2.loop
   0.36%  rav1e  rav1e  [.] rav1e_sad4x4_sse2.loop
   0.15%  rav1e  rav1e  [.] rav1e_sad8x8_sse2.loop
   0.05%  rav1e  rav1e  [.] rav1e_sad16x16_sse2
   0.04%  rav1e  rav1e  [.] rav1e_sad4x4_sse2
   0.01%  rav1e  rav1e  [.] rav1e_sad8x8_sse2
   0.01%  rav1e  rav1e  [.] rav1e_sad16x32_sse2.loop
   0.00%  rav1e  rav1e  [.] rav1e_sad32x32_avx2
   0.00%  rav1e  rav1e  [.] rav1e_sad16x8_sse2.loop
   0.00%  rav1e  rav1e  [.] rav1e_sad64x64_avx2

I basically want the .loop's to be merged with the main function.

I'm also noticing that build_asm_files isn't rerun when build.rs is modified and I have to delete the release folder. This surprises me somewhat, since I could have sworn that in the past it reran whenever it was modified.

EDIT: It seems the hash_changed does not consider whether build.rs has changed.

[lu-zero]

I'll add build.rs to the hash in another commit. -x would break linking.

Please open an issue to the nasm upstream.

[KyleSiefring]

Doesn't this just remove all symbols???

[KyleSiefring]

LGTM