Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always-true if statement in encode_partition_topdown() #2980

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

redzic
Copy link
Collaborator

@redzic redzic commented Aug 8, 2022

must_split is always false in this branch, because if it was true, the previous branch would have been taken.

@codecov-commenter
Copy link

Codecov Report

Merging #2980 (934f269) into master (97efc96) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
- Coverage   86.58%   86.49%   -0.09%     
==========================================
  Files          87       87              
  Lines       33886    33879       -7     
==========================================
- Hits        29340    29304      -36     
- Misses       4546     4575      +29     
Impacted Files Coverage Δ
src/encoder.rs 87.31% <100.00%> (-0.04%) ⬇️
src/context/frame_header.rs 66.06% <0.00%> (-2.27%) ⬇️
src/asm/x86/lrf.rs 91.59% <0.00%> (-1.90%) ⬇️
src/header.rs 68.93% <0.00%> (-1.65%) ⬇️
src/context/transform_unit.rs 89.78% <0.00%> (-0.72%) ⬇️
src/rdo.rs 85.74% <0.00%> (-0.05%) ⬇️
src/cpu_features/x86.rs 39.58% <0.00%> (ø)
v_frame/src/plane.rs 88.90% <0.00%> (+0.11%) ⬆️
src/context/mod.rs 92.63% <0.00%> (+1.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@redzic redzic merged commit 0bee40b into xiph:master Aug 8, 2022
@redzic redzic deleted the topdown-fix branch August 8, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants