Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise plane::as_region #3091

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Optimise plane::as_region #3091

merged 1 commit into from
Jan 15, 2023

Conversation

shssoichiro
Copy link
Collaborator

This is part of a series of commits authored by @maj160 to improve performance of rav1e.

This commit results in an overall performance improvement of about 2% at speed 2 10-bit:

Benchmark 1: ~/Downloads/rav1e_master -s 2 --quantizer 64 ~/xiph-media-files/objective-1-fast-10bit/speed_bag_640x360_60f.y4m -y -o /dev/null
  Time (mean ± σ):     43.646 s ±  0.088 s    [User: 43.656 s, System: 0.170 s]
  Range (min … max):   43.471 s … 43.787 s    10 runs

Benchmark 2: ~/Downloads/rav1e_mod -s 2 --quantizer 64 ~/xiph-media-files/objective-1-fast-10bit/speed_bag_640x360_60f.y4m -y -o /dev/null
  Time (mean ± σ):     42.919 s ±  0.082 s    [User: 42.934 s, System: 0.169 s]
  Range (min … max):   42.813 s … 43.039 s    10 runs

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Base: 86.93% // Head: 86.91% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8cc0b24) compared to base (4fb2a27).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3091      +/-   ##
==========================================
- Coverage   86.93%   86.91%   -0.03%     
==========================================
  Files          83       83              
  Lines       33035    33050      +15     
==========================================
+ Hits        28720    28725       +5     
- Misses       4315     4325      +10     
Impacted Files Coverage Δ
src/frame/plane.rs 100.00% <100.00%> (ø)
src/tiling/plane_region.rs 88.05% <100.00%> (+0.41%) ⬆️
src/cpu_features/x86.rs 39.58% <0.00%> (-2.09%) ⬇️
src/asm/x86/lrf.rs 92.22% <0.00%> (-1.90%) ⬇️
src/context/mod.rs 91.57% <0.00%> (-1.06%) ⬇️
src/rdo.rs 85.62% <0.00%> (ø)
src/me.rs 95.70% <0.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This is part of a series of commits authored by @maj160 to improve performance of rav1e.

This commit results in an overall performance improvement of about 2% at speed 2 10-bit:

```
Benchmark 1: ~/Downloads/rav1e_master -s 2 --quantizer 64 ~/xiph-media-files/objective-1-fast-10bit/speed_bag_640x360_60f.y4m -y -o /dev/null
  Time (mean ± σ):     43.646 s ±  0.088 s    [User: 43.656 s, System: 0.170 s]
  Range (min … max):   43.471 s … 43.787 s    10 runs

Benchmark 2: ~/Downloads/rav1e_mod -s 2 --quantizer 64 ~/xiph-media-files/objective-1-fast-10bit/speed_bag_640x360_60f.y4m -y -o /dev/null
  Time (mean ± σ):     42.919 s ±  0.082 s    [User: 42.934 s, System: 0.169 s]
  Range (min … max):   42.813 s … 43.039 s    10 runs
```
@shssoichiro shssoichiro merged commit 94e0ef0 into xiph:master Jan 15, 2023
@shssoichiro shssoichiro deleted the maj-optim-5 branch January 15, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants