Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving game crashes the server #11

Closed
xird opened this issue Apr 12, 2014 · 2 comments
Closed

Leaving game crashes the server #11

xird opened this issue Apr 12, 2014 · 2 comments
Labels
Milestone

Comments

@xird
Copy link
Owner

xird commented Apr 12, 2014

I haven't tried this again, but this it what happened:

  • Two player game in progress
  • My secondary browser, Firefox, timed out and the monster got killed as it should
  • My primary browser, Chrome, showed that I'd won
  • I clicked "leave game"
  • Server crashed

ROKServerGame.js:1522: * FIXME: Clicking Leave Game after opponent disconnected crashed the server.

@xird xird added this to the MVP milestone Apr 12, 2014
@xird xird added the bug label Apr 12, 2014
@S-Bartfast
Copy link
Collaborator

In particular it appears the the crashed is caused on what is currently line 99 of ROKServerLobby.js which reads:
target_socket.emit("update_lobby", send_object);
target_socket is "undefined".

@xird
Copy link
Owner Author

xird commented Feb 17, 2016

I've added more checks to make sure the socket exists before trying to emit to it.

@xird xird closed this as completed Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants