Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken HTML layout in thread #40

Closed
riking opened this issue Jan 24, 2018 · 1 comment
Closed

Broken HTML layout in thread #40

riking opened this issue Jan 24, 2018 · 1 comment
Assignees

Comments

@riking
Copy link

riking commented Jan 24, 2018

Seen on: https://jul.rustedlogic.net/thread.php?id=18227&page=3

The first three posts on the page have no wrapping div. Also, there's no identifying class name on the post body - ideally, the div would have class=post.

<table width="100%">...title...</table>
<table width="100%">...pages...</table>
<div style="position:relative">
	</div>
<table class="table" cellspacing="0">post</table>
<table class="table" cellspacing="0">post</table>
<table class="table" cellspacing="0">post</table>
<div style="position:relative"><table class="table" cellspacing="0">post</table></div>
<div style="position:relative"><table class="table" cellspacing="0">post</table></div>
<div style="position:relative"><table class="table" cellspacing="0">post</table></div>
@Xkeeper0
Copy link
Owner

That looks like something from post-processing, i.e. not the actual source of the page (devtools?)

Part of the problem is that the code was changed at one point to move from "enclose entire thread in one table" to "each post is its own table" (to prevent posts from "table breaking" if they had too wide of an image or something).

There's a spurious <tr> getting added here:

jul/thread.php

Line 372 in a6a22e7

$postlist .= '<tr>';

The "position: relative" <div>s are added here, which may not be getting added to "custom sidebars":

<div style='position:relative'>

(I'm not actually sure why the position-relative is there, to be honest)

@Xkeeper0 Xkeeper0 self-assigned this Dec 11, 2018
Xkeeper0 added a commit that referenced this issue Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants