Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Flavour text wrapping #4

Closed
GonePh1shing opened this issue May 27, 2019 · 3 comments
Closed

[Feature Request] Flavour text wrapping #4

GonePh1shing opened this issue May 27, 2019 · 3 comments

Comments

@GonePh1shing
Copy link

Flavour text on linked unique items currently renders on a single line. This results in reduced readability when viewed in Discord.

Example here; this was captured on a 1080p screen. Compare that to the original image served by the bot, and the difference is night and day.

Even when viewed zoomed in, it is less readable than it could be. If the rendered image was less wide, Discord would allow for a larger zoom that would result in the text being bigger on screen.

Wrapping the flavour text such that it is no wider than the widest mod on the item would fix this.

@xKynn
Copy link
Owner

xKynn commented May 27, 2019

It does actually wrap for a readable amount, iirc its 7 words per line. The issue with that one is the <\br> tag which didn't get replaced by a space allowing the string to be parsed literally as a single word.

@xKynn
Copy link
Owner

xKynn commented May 27, 2019

It's either splitting into lines at the br tags or 7 words I can't remember but it does do multiline

@xKynn
Copy link
Owner

xKynn commented May 27, 2019

handles br tag at https://github.com/xKynn/PoE.py/blob/master/poe/utils.py#L86
I'll be adding support for the other tag soon

@xKynn xKynn closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants