Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment variable VSINSTALLDIR is missing from xrepo virtualenv #1807

Closed
xq114 opened this issue Nov 5, 2021 · 2 comments
Closed

environment variable VSINSTALLDIR is missing from xrepo virtualenv #1807

xq114 opened this issue Nov 5, 2021 · 2 comments
Labels
bug improvement
Milestone
v2.6.1

Comments

@xq114
Copy link
Contributor

xq114 commented Nov 5, 2021

描述问题

image
image

如图，cl可以识别到说明加载了msvc的环境，但环境里缺少VSINSTALLDIR环境变量

期待的结果

xrepo加载的msvc环境可以与vs环境一致

相关环境

请提供编译和运行环境信息，下面是一些必须填写的基础信息，便于我们针对性排查问题：

  • xmake版本：2.5.9
  • xmake运行平台：windows
  • xmake目标平台：windows
@xq114 xq114 added the bug label Nov 5, 2021
@waruqi
Copy link
Member

waruqi commented Nov 6, 2021

你可以试试在这里加上

xmake/xmake/toolchains/msvc/load.lua

Line 65 in 95dea5a

_add_vsenv(toolchain, "WindowsSDKVersion")

@xq114
Copy link
Contributor Author

xq114 commented Nov 6, 2021

#1808

@xq114 xq114 closed this as completed Nov 6, 2021
@waruqi waruqi added this to the v2.6.1 milestone Nov 6, 2021
@xq114 xq114 mentioned this issue Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug improvement
Projects
None yet
Milestone
v2.6.1
Development

No branches or pull requests
2 participants
@waruqi @xq114