Corrected counting contentHeight in ActionController #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I noticed if calculated
contentHeight
inActionController
, we didn't usecollectionView.contentInset.bottom
. I think it's not correct.For example, you can see
DynamicsActionController
that it usescollectionView.contentInset.bottom
for calculatecontentHeight
.But both this class use
setUpContentInsetForHeight
.So, now
var topInset = height - contentHeight - safeAreaInsets.bottom
(forActionController
) ignorecollectionView.contentInset.bottom
and the alert attache to SafeArea without a inset.I tried to fix it. 🙃