Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/access level #112

Merged
merged 16 commits into from
Jan 27, 2021
Merged

Feature/access level #112

merged 16 commits into from
Jan 27, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jan 25, 2021 •
edited
Loading

This PR includes:

  • The access level feature which allows requests to have elevated permissions based on a JWT claim containing some capability.
  • A fix to the behavior around an item's TTL.

@joe94 joe94 linked an issue Jan 25, 2021 that may be closed by this pull request
Upgrade super use feature #99
Closed
@guardrails
Copy link

guardrails bot commented Jan 25, 2021 •
edited
Loading

⚠️ We detected security issues in this pull request:

Vulnerable Libraries (1)

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@joe94 joe94 marked this pull request as draft January 25, 2021 22:25
@joe94 joe94 linked an issue Jan 25, 2021 that may be closed by this pull request
TTL Validation Questions #111
Closed
@joe94 joe94 mentioned this pull request Jan 25, 2021
Closed
kristinapathak
kristinapathak suggested changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comments on names of things. The whole flow and organization looks great! 👍

auth/accessLevel.go Outdated Show resolved Hide resolved
auth/constructor.go Show resolved Hide resolved
auth/provide.go Show resolved Hide resolved
store/provide.go Show resolved Hide resolved
store/transport.go Show resolved Hide resolved
auth/accessLevel.go Show resolved Hide resolved
auth/accessLevel.go Outdated Show resolved Hide resolved
auth/bearerTokenFactory.go Outdated Show resolved Hide resolved
auth/bearerTokenFactory.go Outdated Show resolved Hide resolved
@joe94 joe94 mentioned this pull request Jan 26, 2021
Closed
kristinapathak
kristinapathak approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@codecov
Copy link

codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #112 (3017153) into main (52fd369) will increase coverage by 0.69%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   41.86%   42.56%   +0.69%     
==========================================
  Files          15       15              
  Lines         762      773      +11     
==========================================
+ Hits          319      329      +10     
- Misses        426      427       +1     
  Partials       17       17
Impacted Files Coverage Δ
store/endpoint.go 95.83% <ø> (ø)
store/handler.go 0.00% <ø> (ø)
store/provide.go 0.00% <0.00%> (ø)
store/store.go 100.00% <ø> (ø)
store/transport.go 86.86% <100.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52fd369...9e9720e. Read the comment docs.

@joe94 joe94 marked this pull request as ready for review January 27, 2021 19:19
@joe94 joe94 requested a review from kcajmagic January 27, 2021 20:08
kcajmagic
kcajmagic suggested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@kcajmagic kcajmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor change

deploy/packaging/argus_spruce.yaml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@joe94 joe94 merged commit 1dbdab5 into main Jan 27, 2021
@joe94 joe94 deleted the feature/accessLevel branch January 27, 2021 22:08
@joe94 joe94 mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TTL Validation Questions Upgrade super use feature
3 participants
@joe94 @kcajmagic @kristinapathak