Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the spans to match the spec. #16

Open
schmidtw opened this issue Apr 4, 2019 · 4 comments
Open

Implement the spans to match the spec. #16

schmidtw opened this issue Apr 4, 2019 · 4 comments

Comments

@schmidtw
Copy link
Member

schmidtw commented Apr 4, 2019

https://github.com/Comcast/wrp-c/wiki/Web-Routing-Protocol#simple-request-response-definition

Should be an array of structs not strings.

https://github.com/Comcast/wrp-c/blob/master/src/wrp-c.h#L67

@kristinapathak kristinapathak added the hacktoberfest good issue for hacktoberfest label Sep 30, 2019
@kristinapathak
Copy link
Contributor

line of interest:
https://github.com/xmidt-org/wrp-go/blob/master/wrp/messages.go#L240

should be implemented to match this part of the spec:
(optional) An array of arrays of timing values as a list in the format: "parent" (string), "name" (string), "start time" (int), "duration" (int), "status" (int)

@kristinapathak kristinapathak added hacktoberfest good issue for hacktoberfest and removed hacktoberfest good issue for hacktoberfest labels Sep 30, 2019
@iDevoid
Copy link

iDevoid commented Oct 6, 2019

Hi @kristinaspring
Based on this doc I found that CRUD struct and Simple Request-Response has almost identical data structure.. CRUD has String path but Simple Request-Response has String span_parent..
I am sure both of the struct has different uses. but, any considering to merge these structs?

and based on this.. I found that CRUD also has Array.Array spans, but the go version of CRUD has Spans [][]string instead.. this is related, isn't this?

@kristinapathak
Copy link
Contributor

Hi,

I believe @schmidtw has more information on the first point, but yes, I would think both CRUD and Simple Request-Response should have their spans value changed in the same way.

@kristinapathak kristinapathak removed the hacktoberfest good issue for hacktoberfest label Nov 1, 2019
@schmidtw
Copy link
Member Author

schmidtw commented Jun 9, 2020

I found this PR in webpa-common that appears to do the work described here. Can we use this PR?

https://github.com/xmidt-org/webpa-common/pull/295/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants