Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to start: with "_on_connect() missing 1 required positional argument: 'initial_data" #8

Closed
JonesN3 opened this issue Oct 13, 2015 · 4 comments

Comments

@JonesN3
Copy link

JonesN3 commented Oct 13, 2015

Hangups is global and works correctly. I recently ran this bot on an older computer without problem, maybe issues with a newer version of hangups?

Client unexpectedly disconnected:
_on_connect() missing 1 required positional argument: 'initial_data'
Traceback (most recent call last):
File "/home/user/projects/hubot/node_modules/hubot-hangups/HangoutsBot/hangupsbot.py", line 137, in run
loop.run_until_complete(self._client.connect())
File "/usr/lib/python3.4/asyncio/base_events.py", line 208, in run_until_complete
return future.result()
File "/usr/lib/python3.4/asyncio/futures.py", line 243, in result
raise self._exception
File "/usr/lib/python3.4/asyncio/tasks.py", line 298, in _step
result = coro.throw(exc)
File "/usr/local/lib/python3.4/dist-packages/hangups/client.py", line 99, in connect
yield from self._listen_future
File "/usr/lib/python3.4/asyncio/futures.py", line 348, in iter
yield self # This tells Task to wait for completion.
File "/usr/lib/python3.4/asyncio/tasks.py", line 351, in _wakeup
value = future.result()
File "/usr/lib/python3.4/asyncio/futures.py", line 243, in result
raise self._exception
File "/usr/lib/python3.4/asyncio/tasks.py", line 300, in _step
result = coro.send(value)
File "/usr/local/lib/python3.4/dist-packages/hangups/channel.py", line 214, in listen
yield from self._longpoll_request()
File "/usr/local/lib/python3.4/dist-packages/hangups/channel.py", line 343, in _longpoll_request
yield from self._on_push_data(chunk)
File "/usr/local/lib/python3.4/dist-packages/hangups/channel.py", line 364, in _on_push_data
yield from self.on_connect.fire()
File "/usr/local/lib/python3.4/dist-packages/hangups/event.py", line 50, in fire
yield from gen
File "/usr/local/lib/python3.4/dist-packages/hangups/event.py", line 48, in fire
gen = observer(_args, *_kwargs)
TypeError: _on_connect() missing 1 required positional argument: 'initial_data'

@luckymancvp
Copy link

me2

@wardellbagby
Copy link
Contributor

@luckymancvp, and @bigjones, It'll probably be a while before @xmikos takes a look at this to get it fixed, but if I figure it out before he does, I'll submit a pull request to his branch so you all can use that.

Really, I'd just recommend downgrading to back to hangups 0.2.10, since 0.3.0 is the one that causes this crash.

@wardellbagby
Copy link
Contributor

@luckymancvp and @bigjones, I'm a man of my word and the pull request is now active. I've only done light testing but I can verify that it does indeed start-up and it will run. I haven't tested all of the commands, but I fixed all of the ones that I saw would be an issue (generally the ones related to changing things in the conversation.)

This is, of course, based off of @xmikos and not my own, so there should be no incompatibility issues temporarily using my branch until either @xmikos accepts the pull request or denies it in lieu of his own. Check out #9 for the info on my changes.

@JonesN3
Copy link
Author

JonesN3 commented Oct 22, 2015

Nice work @wardellchandler! Will let you know if I find any problems with the fix.

@JonesN3 JonesN3 closed this as completed Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants