Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute changes from Chrome Dev Tools are not taken into account #74

Closed
wherget opened this issue Oct 31, 2014 · 4 comments
Closed

Attribute changes from Chrome Dev Tools are not taken into account #74

wherget opened this issue Oct 31, 2014 · 4 comments
Milestone

Comments

@wherget
Copy link

wherget commented Oct 31, 2014

Steps to reproduce:

Expected Behaviour:

  • Scene turns dark

Actual Behaviour:

  • nothing happens

Additional Comments:
A similar maneuver using Firebug in Firefox succeeds, as does setting the attribute from Chrome's console when using getElementById() (either using dot-notation or setAttribute). It seems the Dev Tools' Element view writes to the DOM via some means that xml3d.js is not monitoring. It would however be very helpful if this worked, since in web development, rapid iteration using the Dev Tools is a very important technique.

@ksons
Copy link

ksons commented Nov 1, 2014

To my knowledge, the Chrome Dev Tools spawn no MutationEvents, which the implementation is listening for. @lachsen started using MutationObservers on branch proto-config (746d541). This might fix the issue.

@lachsen
Copy link
Contributor

lachsen commented Nov 1, 2014

Yes, MutationObservers will fix this issue. I think we can merge the proto-config branch to develop soon as everything seems to work so far.

@ksons
Copy link

ksons commented Nov 13, 2014

Fixed by 746d541

@ksons ksons added this to the 4.8 Release milestone Dec 5, 2014
@ksons
Copy link

ksons commented Dec 19, 2014

Included in 4.8 release

@ksons ksons closed this as completed Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants