Join GitHub today
Create xmlunit-assertj module #120
This was referenced
May 13, 2018
I think it would be a good idea to rename the 'negative' assertions methods so that they are closer to the AssertJ naming schema: (e.g.
A nitpick: Replace
I wonder whether we'd want to put the module into a profile that is triggered if Java is not Java6 in order to avoid the Travis CI problem. So far I haven't seen a reason to drop Java6 support for Core but wouldn't see any problem with the assertj module requiring even Java8 instead. I've been cutting releases using Java8 anyway.
You may want to override the compiler properties in the module's POM if you want to use Java7+ features.
Thanks, merged. I'l tweak a few things later like adding license headers, adding to the release notes and so on. Also I now realized the openjdk6 build has been broken since I switched xmlunit.org to https so the error wasn't related to the PR at all - something I need to look into separately. Many thanks again!
It would be nice if you (or anybody else more familiar with AssertJ than myself) could add an example to the README and maybe even add a page to the user guide.