Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared adaptive filter in lib_ic #362

Closed
hughhop opened this issue Aug 5, 2022 · 4 comments
Closed

Use shared adaptive filter in lib_ic #362

hughhop opened this issue Aug 5, 2022 · 4 comments

Comments

@hughhop
Copy link

hughhop commented Aug 5, 2022

No description provided.

@mbanth
Copy link
Collaborator

mbanth commented Aug 9, 2022

I'm unsure of the purpose or scope of this issue since lib_interference_canceller already uses a shared adaptive filter implementation, namely the one in the Voice Toolbox (lib_voice_toolbox). Given that lib_interference_canceller is only used in applications that are either in maintenance phase or soon will be, I do not see a business case to enhance this implementation of the IC.

@hughhop
Copy link
Author

hughhop commented Aug 9, 2022

i dont think there will be any changes to lib_interference_canceller (as in the old separate repo) is that what you mean?

this is about fwk_voice/modules/lib_ic using the shared adaptive filter as described in issue 356

@uvvpavel maybe you can comment about how this relates to the generic adaptive filter in lib_voice_toolbiox

@mbanth
Copy link
Collaborator

mbanth commented Aug 9, 2022

i dont think there will be any changes to lib_interference_canceller (as in the old separate repo) is that what you mean?

this is about fwk_voice/modules/lib_ic using the shared adaptive filter as described in issue 356

I understand now. I mis-interpreted 'lib_ic' to mean the old lib_interference_canceller.

@mbanth
Copy link
Collaborator

mbanth commented Oct 7, 2022

A review by @andrewdewhurst and myself has concluded that we will not work on this issue.

@mbanth mbanth closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants