Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple content types from the JS SDK, remove ContentTypeComposite #628

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Jun 14, 2024

Summary

  • Removed internal content types and their primitives
  • Added content types and primitives from their respective packages
  • Removed ContentTypeComposite

BREAKING CHANGE

This removes exports from the JS SDK and is a breaking change. The next release will be a major one.

@rygine rygine requested a review from a team June 14, 2024 15:49
Copy link

changeset-bot bot commented Jun 14, 2024

⚠️ No Changeset found

Latest commit: 4f86be5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rygine rygine requested a review from fabriguespe as a code owner June 14, 2024 15:53
Copy link

cloudflare-workers-and-pages bot commented Jun 14, 2024

Deploying xmtp-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9619322
Status: ✅  Deploy successful!
Preview URL: https://502190be.xmtp-js.pages.dev
Branch Preview URL: https://rygine-content-type-decouple.xmtp-js.pages.dev

View logs

@rygine rygine force-pushed the rygine/content-type-decouple branch from 3690c0c to b5d9ff6 Compare June 14, 2024 17:03
@rygine rygine changed the title Decouple content types from the JS SDK Decouple content types from the JS SDK, remove ContentTypeComposite Jun 14, 2024
@rygine rygine merged commit d36e8f3 into main Jun 14, 2024
9 checks passed
@rygine rygine deleted the rygine/content-type-decouple branch June 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants