Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can link different nodes inputs with other nodes outputs #12

Closed
scalamorphing opened this issue Jun 14, 2016 · 7 comments
Closed

Comments

@scalamorphing
Copy link
Contributor

No description provided.

@scalamorphing scalamorphing added this to the Rewrite application using Angular 2 and ECMAScript6 milestone Jun 14, 2016
@scalamorphing scalamorphing self-assigned this Jun 14, 2016
@scalamorphing
Copy link
Contributor Author

@nailxx I am going to rewrite horrible EditorBus service. It should be rewritten now using xstream. I need this event bus for managing every event we need to emit and broadcast in our components.

@nkrkv
Copy link
Member

nkrkv commented Jun 14, 2016

OK if it is required by the feature. It is.

@scalamorphing
Copy link
Contributor Author

scalamorphing commented Jun 15, 2016

I deleted editor-remake branch and now I am working in feature-link-pins branch.

@scalamorphing
Copy link
Contributor Author

scalamorphing commented Jun 15, 2016

Issue solution roadmap

  1. Refactor EditorBus service using xstream.
  2. Refactor all services of the application.
  3. Write behaviour tests for this user story.

@scalamorphing
Copy link
Contributor Author

I had a discussion with @brusherru and we found that derivablejs fits our needs entirely.

@scalamorphing
Copy link
Contributor Author

Proposal

@nailxx @brusherru I am going to use ramda (since it's mature, it's recommended by author of derivablejs and it fits all our needs and even more) instead of immutable.js for managing state of client application. I am sure that side-effects should be localized for better testing experience. We should not fail into endless debugging of our tests. All components should be stateless. I guess that it's a good practice. If you are not sure if it's a good idea then I can spend some time on research.
At this moment I need stateless events: I must be sure that events data can't be changed because it would be really tedious to find such bugs while our appilcation growth.

@nkrkv nkrkv removed this from the Rewrite application using Angular 2 and ECMAScript6 milestone Jun 21, 2016
@nkrkv
Copy link
Member

nkrkv commented Jun 21, 2016

No longer relevant

@nkrkv nkrkv closed this as completed Jun 21, 2016
@scalamorphing scalamorphing removed their assignment Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants