Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Guide - Custom Types #1532

Closed
Cesar-S opened this issue Nov 9, 2018 · 5 comments
Closed

Verify Guide - Custom Types #1532

Cesar-S opened this issue Nov 9, 2018 · 5 comments
Labels

Comments

@Cesar-S
Copy link
Contributor

Cesar-S commented Nov 9, 2018

Expected behavior

Should it be possible to connect output-self node to input-time?

Actual behavior

Following the tutorial at the end you can not connect "time" with "unpack".

Realized the patch "time" (https://xod.io/docs/guide/custom-types/time.patch.png)

It is not possible to connect it to "unpack" (https://xod.io/docs/guide/custom-types/unpack-example.patch.png) ,instead of output-self you must use output-time

@nkrkv nkrkv added the triage label Nov 9, 2018
@nkrkv
Copy link
Member

nkrkv commented Nov 12, 2018

To me, everything seems right. The output-self node is a marker, not a terminal actually. It has no inputs and no outputs. The sole purpose of output-self on a patch is to tell XOD that this patch defines a new type. XOD will generate the output-time and input-time as a consequence of output-self placement.

The example used in the guide is not fake and it is an actual project which you can download here https://xod.io/docs/guide/custom-types/time.xodball. See the unpack-example patch. There time is linked with unpack.

If I do not understand you correctly, and there’s indeed a bug out there, feel free to reopen the issue.

@nkrkv nkrkv closed this as completed Nov 12, 2018
@nkrkv nkrkv added wontfix and removed triage labels Nov 12, 2018
@Cesar-S
Copy link
Contributor Author

Cesar-S commented Nov 12, 2018

Dear @nkrkv , eh downloaded the example and it works correctly, but I have the error in unpack.

I open another XOD, I create two patches, in a copied node "time" and when I want to copy unpack there is an error.

"Invalid paste
The clipboard contains references to missing patches: @ / input-time.
Try to install libraries which provide the required patches. "

For some reason I do not have Input-time and output-time in my libraries.

The error is that by not having them use input-datatime

@Cesar-S
Copy link
Contributor Author

Cesar-S commented Nov 12, 2018

As you might notice, at the moment you place an output-self node on a constructor patch two new terminal nodes are automatically generated next to the constructor patch. In our example, they are input-time and output-time.

I found my error, translation or reading problem
thank you for your time excuse me

@nkrkv
Copy link
Member

nkrkv commented Nov 12, 2018

Oh, the message is indeed misleading. I’m going to rephrase the issue and promote it to a tweak.

@nkrkv nkrkv reopened this Nov 12, 2018
@nkrkv nkrkv added triage and removed wontfix labels Nov 12, 2018
@Cesar-S
Copy link
Contributor Author

Cesar-S commented Nov 12, 2018

Something to add that might be useful, when I did the tutorial, look for the xodball I did not find this link https://xod.io/docs/guide/custom-types/time.xodball
I've looked again and no this.

With a little searching I come here https://github.com/xodio/xod-docs/tree/master/docs/guide/custom-types if the files are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants