Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Message Conventions #9

Closed
nkrkv opened this issue Jun 1, 2016 · 5 comments
Closed

Commit Message Conventions #9

nkrkv opened this issue Jun 1, 2016 · 5 comments

Comments

@nkrkv
Copy link
Member

nkrkv commented Jun 1, 2016

We could use AngularJS commit message conventions (https://gist.github.com/stephenparish/9941e89d80e2bc58a153) to make history more clear.

I don't think we should be very verbosive in body message until the release but other practices would be handy.
@scalamorphing
Copy link
Contributor

@nailxx I will join the discussion as soon as possible.

Proposal

  • I fully agree that we need prefixes in commit summary.
  • I think that it's really handy to specify scopes of changes.
  • We just need to standardize a list of recommended prefixes and scopes.

@nkrkv
Copy link
Member Author

nkrkv commented Jun 14, 2016

@brusherru Check this out.

@brusherru
Copy link
Contributor

Checked. But as I see in the commit history — in the general case, write only subject line?

@scalamorphing
Copy link
Contributor

@nailxx @brusherru I think that it's preferred way.

@nkrkv
Copy link
Member Author

nkrkv commented Jun 21, 2016

We already use it to an adequate degree.

@nkrkv nkrkv closed this as completed Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkrkv @brusherru @scalamorphing