-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionsManager.buildConfig
only includes some options
#101
Comments
I have strong suspicions it is related to sindresorhus/deep-assign#6 |
@jamestalmage I don't think so. I explicitly use v1 of deep-assign, not v2 as mentioned there: https://github.com/sindresorhus/xo/blob/9fce4fb1a59abb28a47b2bbbc0ce3d922eb163ab/package.json#L67 |
Hmm. Looking at the code, I don't see any reason Is it only affecting |
You explicitly pluck out only some of the options here: https://github.com/sindresorhus/xo/blob/9fce4fb1a59abb28a47b2bbbc0ce3d922eb163ab/options-manager.js#L78-L82
Not sure. That's where I noticed it. |
Why on earth did I do that? |
Fixed since 3621ac5 |
It's filtering out many options, like
cwd
,filename
, etc.I had to work around it here, but would like to know the reason for it being like that. @jamestalmage ?
Probably one of the reasons for sindresorhus/atom-linter-xo#19
The text was updated successfully, but these errors were encountered: