Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionsManager.buildConfig only includes some options #101

Closed
sindresorhus opened this issue Apr 9, 2016 · 6 comments
Closed

optionsManager.buildConfig only includes some options #101

sindresorhus opened this issue Apr 9, 2016 · 6 comments

Comments

@sindresorhus
Copy link
Member

It's filtering out many options, like cwd, filename, etc.

I had to work around it here, but would like to know the reason for it being like that. @jamestalmage ?

Probably one of the reasons for sindresorhus/atom-linter-xo#19

@jamestalmage
Copy link
Contributor

I have strong suspicions it is related to sindresorhus/deep-assign#6

@sindresorhus
Copy link
Member Author

@jamestalmage I don't think so. I explicitly use v1 of deep-assign, not v2 as mentioned there: https://github.com/sindresorhus/xo/blob/9fce4fb1a59abb28a47b2bbbc0ce3d922eb163ab/package.json#L67

@jamestalmage
Copy link
Contributor

Hmm.

Looking at the code, I don't see any reason cwd and filename wouldn't be copied.

Is it only affecting lintText?

@sindresorhus
Copy link
Member Author

Looking at the code, I don't see any reason cwd and filename wouldn't be copied.

You explicitly pluck out only some of the options here: https://github.com/sindresorhus/xo/blob/9fce4fb1a59abb28a47b2bbbc0ce3d922eb163ab/options-manager.js#L78-L82

Is it only affecting lintText?

Not sure. That's where I noticed it.

@jamestalmage
Copy link
Contributor

Why on earth did I do that?

@marionebl
Copy link
Contributor

Fixed since 3621ac5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants