Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties with [YamlIgnore] being accessed during serialization #3

Closed
roji opened this issue Mar 3, 2014 · 1 comment
Closed

Properties with [YamlIgnore] being accessed during serialization #3

roji opened this issue Mar 3, 2014 · 1 comment

Comments

@roji
Copy link
Contributor

roji commented Mar 3, 2014

[YamlIgnore] doesn't exactly work - properties having it are still invoked, and their results are discarded only afterwards.

For example, if a property with [YamlIgnore] throws an exception, this will make the serialization process abort.

To repro, go to the ContainsIgnore class in SerializationTests.cs and throw exceptions from the getter/setter. I've created a commit that demonstrates this for the original YamlDotNet here: roji/YamlDotNet@648463e

@xoofx
Copy link
Owner

xoofx commented Mar 4, 2014

Sorry, I can't reproduce this in latest SharpYaml I have uploaded the changes in the test in commit f545fd2.

@xoofx xoofx closed this as completed Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants