Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case for SearchPattern on Windows isn't valid #10

Closed
Rohansi opened this issue Dec 4, 2017 · 3 comments
Closed

Special case for SearchPattern on Windows isn't valid #10

Rohansi opened this issue Dec 4, 2017 · 3 comments
Labels

Comments

@Rohansi
Copy link
Contributor

Rohansi commented Dec 4, 2017

Six tests fail on my machine at this line:

Assert.Equal(AllFiles_txt, other.AllFiles_txt);

other.AllFiles_txt does not contain any of the files with an extension beginning with "txt". Perhaps this behavior was removed from Windows?

Windows 10 version 1709, build 16299.98

@Rohansi
Copy link
Contributor Author

Rohansi commented Dec 5, 2017

For clarification, the special case is for search patterns with a three character extension. The results should include any files with an extension starting with those three characters but on my Windows it does not.

@xoofx xoofx added the bug label Dec 6, 2017
@Rohansi
Copy link
Contributor Author

Rohansi commented Jan 7, 2018

This behavior is only for filesystems with 8.3 names enabled. Can check with fsutil behavior query disable8dot3 C: in command prompt running as admin.

I think this special case should be removed and filter twice (once by Windows, once in Zio) so we get consistent results.

@xoofx
Copy link
Owner

xoofx commented Jan 8, 2018

I think this special case should be removed and filter twice (once by Windows, once in Zio) so we get consistent results.

If the OS/API has a different behavior based on a machine wide settings, that's likely the right way to fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants