Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemWatcher on MemoryFileSystem #51

Open
Ellested opened this issue Sep 4, 2020 · 1 comment
Open

FileSystemWatcher on MemoryFileSystem #51

Ellested opened this issue Sep 4, 2020 · 1 comment
Labels

Comments

@Ellested
Copy link

Ellested commented Sep 4, 2020

Just a note, on a couple of things I've come across while working with zio.

I'm using a configuration with a mount file system as the root, which is mounting both physical and memory file systems.

  1. I've noticed that using a watcher on the root, produces a lot of change events from the memory file system. I haven't looked into the details, but I guess the implementation is built around a block write or similar. Anyway, if this behavior is not expected, I could take a deeper look to see if I can find something.

  2. I've also experienced deadlocks when accessing the MemoryFileSystem. I wonder if the library itself is supposed to be thread safe or not. The file system itself obviously have locks, but I'm not sure if I need to protect thread access to the zio API on top of that.

@xoofx
Copy link
Owner

xoofx commented Nov 7, 2020

I've noticed that using a watcher on the root, produces a lot of change events from the memory file system. I haven't looked into the details, but I guess the implementation is built around a block write or similar. Anyway, if this behavior is not expected, I could take a deeper look to see if I can find something.

I can't tell, I have not dug into how much different are the events from a physical compare to the in memory representation.

I've also experienced deadlocks when accessing the MemoryFileSystem. I wonder if the library itself is supposed to be thread safe or not. The file system itself obviously have locks, but I'm not sure if I need to protect thread access to the zio API on top of that.

This should not happen, so it might be a bug in the library.

@xoofx xoofx added the question label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants