Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Path considers all control characters and ':' as invalid #78

Open
bollhals opened this issue Oct 6, 2023 · 1 comment
Open

Comments

@bollhals
Copy link
Contributor

bollhals commented Oct 6, 2023

The ValidatePath function

  • validates that none of the chars is a control character
  • then forwards to ValidatePathImpl, which
    • validates that no ':' exists.

AFAIK the only not allowed char in a linux filesystem is a '\0' char. Windows has a few more.

Therefore I'm wondering whether the validation could change to either:

  • Only validate the common set => no '\0' exists
    OR
  • Allow FS to define their own set of illegal chars to validate via the ctor
@xoofx
Copy link
Owner

xoofx commented May 20, 2024

Maybe related to this old issue #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants