Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English and Arabic Localization #31

Closed
nishan-p opened this issue Oct 14, 2019 · 10 comments
Closed

English and Arabic Localization #31

nishan-p opened this issue Oct 14, 2019 · 10 comments
Labels
awaiting input Waiting for input from the original author

Comments

@nishan-p
Copy link

I'm using English and Arabic Localization for my app and I have used this Pinview within my app. This is automatically changing the alignment from Left to Right. I do not want the change in the alignment.

I want to have the same as it is, like first textfield will start from left and last textfield on the right. I want this similar functionality in both English and Arabic.

@Sobhi-IOS
Copy link

@xornorik can you reslove this issue ?

@xornorik
Copy link
Owner

I had fixed this issue in one of the earlier releases by enforcing the semantic to be left-to-right.

Could you help me with recreating the issue? I have tried changing the language on the device and also editing the "Application language" field in the scheme; it stayed left-to-right as intended.

screenrecord

@xornorik xornorik added the awaiting input Waiting for input from the original author label Mar 31, 2020
@usamabinattique
Copy link

Can you please pinpoint where the semantics needs to be changed because i am facing the same issue

@xornorik
Copy link
Owner

@usamabinattique I've already changed the semantic to force a left-to-right entry and I was able to confirm it by changing the language on the device (gif attached in my previous comment).

Screenshot 2020-04-11 11 59 38

Could you help me recreate this?

@aliakhtar49
Copy link

aliakhtar49 commented Apr 15, 2020

@xornorik By changing language at runtime on the same session , force a left-to-right entry will not work
On new relaunch force a left-to-right entry will work

@xornorik
Copy link
Owner

@aliakhtar49 I tried that, also tried editing the scheme and changing the application language from there. Same result i.e it maintains the left-to-right entry.

ezgif-2-843061718d06

This is when I relaunch after the language change.

@aliakhtar49
Copy link

@xornorik By changing language at runtime (I was referring to in app mechanism we used to change language on button taped irrespective of the system ) where we manually loaded resources our selves

https://stackoverflow.com/questions/31840176/changing-language-on-the-fly-in-swift

@xornorik
Copy link
Owner

@aliakhtar49 Apologies for the late response.
I understood your point about changing the language at runtime. However, my confusion stems from the fact that when the semantic has been hard-coded to be Force Left-to-Right, there should never be a case when the entry begins from the right.
Am I missing something?

@riazhazan
Copy link

@xornorik still when the UI layout is RTL the SVPinView also mirroring, I mean the entry starts from right to left.

@xornorik
Copy link
Owner

xornorik commented Aug 2, 2020

I've added some logic in the latest version (v1.0.9) to fix this issue. Since I'm unable to recreate this at my end, could someone here confirm and close if it has indeed been fixed.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting input Waiting for input from the original author
Projects
None yet
Development

No branches or pull requests

6 participants