-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Russian Translate #385
Conversation
So... We have discussed that we change track selection to be "Композиций выбрано: {}" for plural so we don't have to fight Russian grammar. You can either land it her or I can make a separate pull request after this one is merged |
Also, we have agreed that "ничего не воспроизводится" takes place of "ничего не играет". Did you revert that intentionally? |
Nevermind. Just merge this one and let me fix things :( |
I don't really understand the last commit :) |
Встречал такое в другой локали, которую переводил. Плеер Sonata. Вот часть кода: |
Just a quick heads up about {}: you have to keep it empty and leave the msgid/msgid_plural untouched What you can do however is have msgstr[2] "Songs selected: {}" for instance |
Also if you're sonewhat unfamiliar with git/potfiles you can just use POEditor and give me a heads up when changes are ready to be pulled into the repository! |
@xou816 Take a look at the translation file. |
po/ru.po
Outdated
msgstr[0] "{} песня выбрана" | ||
msgstr[1] "{} песни выбраны" | ||
msgstr[2] "{} песни были выбраны" | ||
msgstr[0] "композиция выбрана {}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you serious? 😭😭😭😭😭😭😭😭😭😭
Подстановка строк в питоне работает совсем иначе, нежели здесь. Более того, там тоже нельзя значение внутри фигурных скобок менять, тк они не позиционные, а именные |
Так скобки вначале должны быть? Если так, то что мы здесь всё переставляем? |
😭😭😭 |
Получается я этим сломал их назначение? |
Just to be clear about how {} works (specific to this project btw):
Again I strongly advise using a GUI editor if you're unfamiliar with this, it will prevent you from editing stuff you shouldn't and will warn you about plurals, etc |
@xou816 As far as I understood, nothing else needs to be changed. |
po/ru.po
Outdated
msgid "Tracks:" | ||
msgstr "Топ треков" | ||
msgstr "Треки" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a colon here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected.
If you do as you suggest, then there should be two translation options: one is a singular number and another is a plural. Not three, as it is now. |
Have you figured out what to do with the extra msgstr? Was it added by mistake or is one plural form still missing? |
Looks to me like a mistake, the file mentions 3 plurals, but we have 4 msgstr entries here |
In this case (in Russian language) - no. Does not exist. |
I removed msgstr [3] from translation. |
No. There is no mistake. There are really three of them. |
Specifically here, when listing, there are only three pronunciations: two plural pronunciations and one singular pronunciation. This is the Russian language. :) |
Thank you both, merged! :) |
No description provided.