Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags are not showing. #3

Open
Rashesh-Bosamiya opened this issue Sep 15, 2017 · 9 comments
Open

Flags are not showing. #3

Rashesh-Bosamiya opened this issue Sep 15, 2017 · 9 comments

Comments

@Rashesh-Bosamiya
Copy link

Rashesh-Bosamiya commented Sep 15, 2017

Country Flags emojis are not supporting.
I am using https://github.com/twitter/twemoji image set.

@xoudini
Copy link
Owner

xoudini commented Sep 15, 2017

I'll need to look into this, what version of Swift are you using?

@Rashesh-Bosamiya
Copy link
Author

Swift 3.0

@xoudini
Copy link
Owner

xoudini commented Sep 15, 2017

Flags work fine on my side, using:

  • Xcode 8.3.3 (8E3004b)
  • Swift 3.1
  • iOS 10.3

Twemoji flags even work without modifications to filenames.

Could you tell me step-by-step how I'd be able to reproduce your issue? It might be an easy fix.

@Rashesh-Bosamiya
Copy link
Author

Tomorrow, I will provide step by step implementation, what I have implemented so far.

Till then, can you send me demo? if you have created one? Or otherwise that is fine.

@xoudini
Copy link
Owner

xoudini commented Sep 15, 2017

You can test the functionality by using the example app provided in the repo. I've mainly run the project through the .xcworkspace so just open the workspace, import the image set you're intending to use, and run the project from there.

@narvindsingh
Copy link

There is Problem in generating charCode from imageCode i.e. "1f1e8-1f1f3" in view controller didSelectItemAt of collection view.

Steps:
if you convert "1f1e8" then charCode and Unicode both generated but if you used "1f1e8-1f1f3" then charter-code not generated also not a Unicode from it.

at this point need some other solution for parsing image name to charter code.
all this problem having with only "-" this signed have in image name.
ex.
*) "23-20e3"
*) "23-20e3"
*) "30-20e3"
*) "32-20e3"
*) "33-20e3"
*) "34-20e3"
*) "35-20e3"
*) "36-20e3"
*) "37-20e3"
*) "38-20e3"
*) "39-20e3"
*) "1f1e9-1f1ea" and all flag have same code patter.

@xoudini
Copy link
Owner

xoudini commented Sep 16, 2017

@narvindsingh, could you elaborate slightly?

Do you mean that flags are converted but as regional indicator symbols and not as complete flags?

Or that all characters with modifiers fail to convert?

@narvindsingh
Copy link

Sure i'll elaborate,

No not like that in that character code in generate for the unicode "1f1e8-1f1f3".
ex. if you want to Convert this name of image "1f170" for this
CharCode is : 127344,
Unicode is : ""\u{0001F170}""

this fine but if you press any flag in that charcode is not generated that why unicode also is not generated.

In that problem is "1f1e8-1f1f3" there is 2 image name 1f1e8 and 1f1f3 that can't be parse this is problem .

@xoudini
Copy link
Owner

xoudini commented Sep 18, 2017

charcode is not generated that why unicode also is not generated

What do you mean by that Unicode is not generated?

In that problem is "1f1e8-1f1f3" there is 2 image name 1f1e8 and 1f1f3 that can't be parse this is problem

The framework takes care of this. As long as two regional indicator symbols immediately follow each other, the framework replaces that sequence with the image named "1f1xx-1f1xx".

Just try the example app, it works exactly as it should there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants